1785225 - Update function2 to new version 2d3a878ef19dd5d2fb188898513610fac0a48621 from 2022-08-17 08:11:51

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Description

[Update Bot]

This update covers 5 commits, including 1 new upstream commit I've never filed a bug on before. (It's the top one.):

---

2d3a878ef19dd5d2fb188898513610fac0a48621 by Gregor Jasny

https://github.com/Naios/function2commit/2d3a878ef19dd5d2fb188898513610fac0a48621
Authored: 2022-08-16 09:30:40 +0200
Committed: 2022-08-17 10:11:51 +0200

chore: silence Visual Studio 2022 (17.3.0) warning

without the following warning is emitted:

include\function2\function2.hpp(1176): warning C4305: '<function-style-cast>': truncation from 'bool (__cdecl *)(void)' to 'bool'

Files Modified:

• include/function2/function2.hpp

---

f569a63cfe369df867a1a4d17aaa12269156536c by Valery Mironov

https://github.com/Naios/function2commit/f569a63cfe369df867a1a4d17aaa12269156536c
Authored: 2022-05-28 02:55:12 +0300
Committed: 2022-06-01 23:20:39 +0200

Fix issue #50

Files Modified:

• include/function2/function2.hpp
• test/noexcept-test.cpp

---

a24bdcf6c439d386eb874886cd17d2cb734fd297 by Nika Layzell

https://github.com/Naios/function2commit/a24bdcf6c439d386eb874886cd17d2cb734fd297
Authored: 2022-05-17 18:40:57 -0400
Committed: 2022-06-01 23:18:39 +0200

Add option to limit empty callable propagation to known types

This approach roughly matches the one used by std::function, explicitly
enumerating the types which are supported for empty propagation.

Fixes #48

Files Modified:

• CMakeLists.txt
• include/function2/function2.hpp
• test/empty-function-call-test.cpp
• test/regressions.cpp

---

035bec21533f484c1b5dd8dd0380109ea431f6a1 by Denis Blank

https://github.com/Naios/function2commit/035bec21533f484c1b5dd8dd0380109ea431f6a1
Authored: 2022-05-16 08:22:29 +0200
Committed: 2022-05-16 08:22:29 +0200

Apply clang format

Files Modified:

• include/function2/function2.hpp

---

a4ca93cc27824bcd878d555813cb06f646976b55 by David Owens

https://github.com/Naios/function2commit/a4ca93cc27824bcd878d555813cb06f646976b55
Authored: 2022-04-06 16:54:26 -0500
Committed: 2022-05-16 08:19:41 +0200

allocator: rename to avoid shadow warning

rename 'allocator' --> '_allocator' to prevent shadowing gcc
declaration.

Signed-off-by: David Owens <[e-mail]>

• Closes #47

Files Modified:

• include/function2/function2.hpp

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6eae236b3d7cce4f1a33e92be6ddcc37e9c8e9cc

Comment 2

[Update Bot]

Attachment: Bug 1785225 - Update function2 to 2d3a878ef19dd5d2fb188898513610fac0a48621

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57abb85704e1
Update function2 to 2d3a878ef19dd5d2fb188898513610fac0a48621 r=nika

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/57abb85704e1