1785241 - Focusing a selected Firefox View tab with the keyboard in HCM does not show focus outline on top of the selected tab outline

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Ray Fambro]

When Firefox View is active in the Dark OS theme (both on macOS HCM/“increase contrast” and without it), the FxView tab does not show focus outline when focused with keyboard.

Expected: when focused with keyboard, the default FxView outline is visible

Comment 1

[Sarah Clements [:sclements]]

I wasn't able to reproduce this on macos. Gijs said he saw the issue on Windows but oddly enough, when I try testing this on Windows via vmware it looks neither Firefox View nor new tab have the focus in HCM (not just Firefox View tab). I think someone who works on a Windows machine might want to verify if this is a bug specific to Firefox View or another issue altogether.

Comment 2

[Kelly Cochrane [:kcochrane]]

I’m seeing this issue on macOS and Windows 11 with or without HCM enabled. It looks like the outline styles for when the Fx View button/tab is selected are simply overriding the default focus outline.

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1785241 - Ensure selected tab outline doesn't override default focus outline of Fx View tab/button r?dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6e992202c04
Ensure selected tab outline doesn't override default focus outline of Fx View tab/button r=dao

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a6e992202c04

Comment 6

[Bogdan Maris, Desktop QA]

Attachment: Gif showing the issue

Reproduced the issue described in comment 0 using an old Nightly build from 2022-08-17. Verified that using latest Firefox 106.0b5 the selector is now visible when selecting (via keyboard) FxView or other tabs.

I do have a question though here, I noticed that if I have the Firefox View tab in view and I use Tab to navigate I can't reach an opened tab from tab bar, but if I have another tab in view and I use Tab to navigate I can reach Firefox View. I'm not sure if this is intended behavior or an issue (I would think this is an issue but not sure, thus the needinfo). Any thoughts?

Comment 7

[Kelly Cochrane [:kcochrane]]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #6)

Created attachment 9296613 [details]
Gif showing the issue

Reproduced the issue described in comment 0 using an old Nightly build from 2022-08-17. Verified that using latest Firefox 106.0b5 the selector is now visible when selecting (via keyboard) FxView or other tabs.

I do have a question though here, I noticed that if I have the Firefox View tab in view and I use Tab to navigate I can't reach an opened tab from tab bar, but if I have another tab in view and I use Tab to navigate I can reach Firefox View. I'm not sure if this is intended behavior or an issue (I would think this is an issue but not sure, thus the needinfo). Any thoughts?

Yeah I'm able to reproduce the same issue. I think it's unrelated to the issue I fixed here, since the focus was previously being applied to Fx View tab just with no visible indication of the focus. I was able to correct that with a small css update.

It looks like it's not focusing the opened tab at all when the Fx View tab is active in the issue you're describing which would involve more than a css update. It should definitely be addressed in a separate ticket, as that's not the expected behavior as far as I know.

Comment 8

[Sarah Clements [:sclements]]

Bogdan, bug 1787979 fixed tab navigation (using Ctrl + Tab for macOS). I'm not sure if this behavior is a regression from that though. We have better keyboard focus support - with just Tab and arrow keys - that might have landed after that. Probably worth filing a new bug though. FWIW, I don't see any issues navigating tabs with Ctrl + Tab on mac.

Comment 9

[Bogdan Maris, Desktop QA]

Thank you both, I logged bug 1793088 for the issue I mentioned earlier. I'm gonna go ahead and close this as verified since this bug was about showing the selector on the tabs.