Closed Bug 1785242 Opened 3 years ago Closed 3 years ago

Firefox View focus order

Categories

(Firefox :: Firefox View, defect, P2)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1780239

People

(Reporter: rfambro, Unassigned)

References

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] )

The current focus order is not logical, as it jumps from the main area under Tab pickup (Get Firefox mobile > X close) to the right panel Independent voices (Try colorways button) and then back to the main area (Recently closed ^ collapse panel).

Expected: Focus moves left-to-right top-to-bottom (for LTR languages such as English), so it would be: Get Firefox mobile > X > Recently closed ^ > Try colorways

I notice that in the smaller window size, the Colorway section moves under Tab Pickup. The Recently closed section is at the bottom. In this scenario, the order of the focus makes sense. Any thoughts here @sarah? @josh?

Flags: needinfo?(sclements)

I suspect this is due to how the grid layout varies depending on the view port/break point.

Flags: needinfo?(sclements)

Hey, Gijs and I talked about this a while ago and he said he thinks there is a way to modify so that focus order reads the main content first before the complementary content. I don't remember the technical details of how it would be done

Flags: needinfo?(gijskruitbosch+bugs)
Severity: -- → S3
Priority: -- → P2
Whiteboard: [fidefe-2022-mr1-firefox-view]

It's ugly but I think the way to fix this would be to use media query observers that then actually reorder the DOM. Would need some testing + code auditing to ensure event listeners etc. stay intact and the custom components don't freak out too much if they get unattached and reattached to the DOM (in theory, it should all work already. In practice...).

Flags: needinfo?(gijskruitbosch+bugs)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.