1785251 - Send wr.renderer_time in a custom ping that keeps to the Legacy Telemetry "main" ping's schedule

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect)

Description

[Chris H-C :chutten]

In bug 1784297 it's unclear if observed shifts in summary statistics are artefacts of "metrics" ping scheduling being different from "main" ping scheduling.

So let's send the instrumentation under observation (wr.renderer_time) in a ping that matches the "main" ping's schedule.

Note that this won't be identical. Because of Telemetry's ephemeral nature, pings are submitted and sent after networking is shut down (via pingsender). Glean doesn't need or have this. But the data contained in the two pings ("main" and... let's call it "pseudo-main") should be identical (modulo bucketing).

To aid in matching ping to ping, I think we may also wish to include some "main" ping identifying marks: the legacy client_id and the profileSubsessionCounter ought to do it.

The original data review for wr.renderer_time and the legacy client_id cover this new ping, but as profileSubsessionCounter has no review, we'll need to get review before landing this.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1785251 - Submit a Glean 'pseudo-main' ping when Telemetry submits a 'main' ping r?TravisLong!

Comment 2

[Chris H-C :chutten]

Attachment: data collection review request

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/probe-scraper/pull/477

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9290452 [details]
data collection review request

data-review+

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes.

2. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, the usual telemetry opt-out UI in preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Not applicable

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool?

No.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e143f0342f09
Submit a Glean 'pseudo-main' ping when Telemetry submits a 'main' ping r=TravisLong

Comment 6

[Cristian Tuns]

Backed out for causing xpcshell failures on test_TelemetryController.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryController.js | xpcshell return code: 0

Comment 7

[Chris H-C :chutten]

Ah, whoops, can't initializeFOG in Android. https://treeherder.mozilla.org/#/jobs?repo=try&revision=6491af5d5dbd2944330c17d9583e0ba76b9c321b for the patched patch.

Comment 8

[Chris H-C :chutten]

And whoops, testResetFOG isn't available in Android either (until bug 1752139). New trypush: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=6a8d6ae663ea35f6dfb0e93466ef9b7a52a73096

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f4340fe8449
Submit a Glean 'pseudo-main' ping when Telemetry submits a 'main' ping r=TravisLong

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1f4340fe8449