Closed Bug 1785282 Opened 2 years ago Closed 2 years ago

Show "Choose what to sync" modal after user is directed to preferences.sync page

Categories

(Firefox :: Firefox View, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: sclements, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] )

Attachments

(1 file)

While working on bug 1784055, I asked UX/product about directing the user to the preferences > sync tab and opening the "Choose what to sync" modal for them when they click on the error state button ("Turn sync on in settings"). This was agreed upon as an improvement over having them click the "Turn on sync" button and then seeing the chooser modal.

However, I've gotten inconsistent results from trying to access the method (which is private, and async and should be refactored to make it more useable) via this.getWindow().gBrowser.contentWindow.gSyncPane._chooseWhatToSync(false); in tab-pickup-container so I didn't include it in the patch for the aforementioned bug.

Severity: -- → S3
Priority: -- → P1
Whiteboard: [fidefe-2022-mr1-firefox-view]
Priority: P1 → P2
Blocks: firefox-view
Assignee: nobody → mconley
Status: NEW → ASSIGNED

What I suggest we do for this is to use a similar mechanism as this: https://searchfox.org/mozilla-central/rev/3f9dcc016dd96a0336d46f4a19aeabdd796ab9e9/browser/components/preferences/sync.js#131-138

Where the URI is used to signal to about:preferences what things to do after loading completes - in this place, to open the "Choose what to sync" dialog. I suspect we can do that using the same convention here with the URI being something like "about:preferences?action=choose-what-to-sync#sync"

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edb1526b906d
Open 'Choose what to sync' dialog when users click 'Turn sync on in settings' in Firefox View. r=sclements
Regressions: 1790098
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: