Closed
Bug 1785287
Opened 2 years ago
Closed 2 years ago
IsInsideNursery null check is not optimised away in all cases
Categories
(Core :: JavaScript: GC, task, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
105 Branch
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
I noticed from looking at the generated code that we have null checks in a few places where it's not possible for a pointer to be null. It turns out that these are from IsInsideNursery. This checks whether its argument is null, and the compiler isn't always able to get rid of this check in all cases.
|
Assignee | |
Comment 1•2 years ago
|
||
It turns out there's only very few places we call this with an argument that may be null.
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/457d764d3379 Stop IsInsideNursery from accepting null argument r=sfink
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•