Open Bug 1785296 Opened 3 years ago Updated 3 years ago

Fix javadoc warnings that turn fatal with JDK18+

Categories

(GeckoView :: General, task, P3)

All
Android
task

Tracking

(Not tracked)

People

(Reporter: RyanVM, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [geckoview:2023h2])

Attachments

(1 obsolete file)

I tried to do this in bug 1785174 but hint javadoc linting failures due to stricter checks around missing comments that were added in version 18.
https://treeherder.mozilla.org/logviewer?job_id=387646945&repo=autoland&lineNumber=34077

Autocomplete.java:1229 | : use of default constructor, which does not provide a comment (android-javadoc)
Autocomplete.java:1172 | : use of default constructor, which does not provide a comment (android-javadoc)
Autocomplete.java:988 | : use of default constructor, which does not provide a comment (android-javadoc)
Autofill.java:36 | : use of default constructor, which does not provide a comment (android-javadoc)
ContentBlocking.java:1281 | : use of default constructor, which does not provide a comment (android-javadoc)
ContentBlocking.java:91 | : use of default constructor, which does not provide a comment (android-javadoc)
ContentBlockingController.java:25 | : use of default constructor, which does not provide a comment (android-javadoc)
CrashReporter.java:42 | : use of default constructor, which does not provide a comment (android-javadoc)
DeprecationSchedule.java:32 | : no initial description (android-javadoc)
DeprecationSchedule.java:26 | : no initial description (android-javadoc)
GeckoResult.java:260 | : no initial description (android-javadoc)
GeckoResult.java:267 | : no initial description (android-javadoc)
GeckoResult.java:644 | : no initial description (android-javadoc)
GeckoRuntimeSettings.java:37 | : use of default constructor, which does not provide a comment (android-javadoc)
GeckoSession.java:2831 | : no initial description (android-javadoc)
GeckoSession.java:6505 | : no initial description (android-javadoc)
GeckoSession.java:3893 | : no initial description (android-javadoc)
GeckoSession.java:1746 | : use of default constructor, which does not provide a comment (android-javadoc)
GeckoView.java:940 | : no initial description (android-javadoc)
MediaSession.java:500 | : use of default constructor, which does not provide a comment (android-javadoc)
PanZoomController.java:155 | : no initial description (android-javadoc)
PanZoomController.java:163 | : no initial description (android-javadoc)
PanZoomController.java:171 | : no initial description (android-javadoc)
ProfilerController.java:58 | : use of default constructor, which does not provide a comment (android-javadoc)
StorageController.java:29 | : use of default constructor, which does not provide a comment (android-javadoc)
StorageController.java:34 | : use of default constructor, which does not provide a comment (android-javadoc)
WebExtension.java:1668 | : use of default constructor, which does not provide a comment (android-javadoc)
WebExtension.java:1698 | : use of default constructor, which does not provide a comment (android-javadoc)
WebExtension.java:2403 | : no initial description (android-javadoc)
WebExtension.java:2412 | : no initial description (android-javadoc)
WebExtension.java:2421 | : no initial description (android-javadoc)
WebExtension.java:2431 | : no initial description (android-javadoc)
WebExtension.java:2442 | : no initial description (android-javadoc)
WebExtension.java:2451 | : no initial description (android-javadoc)
WebExtension.java:2457 | : no initial description (android-javadoc)
WebExtension.java:2465 | : no initial description (android-javadoc)
WebExtension.java:2473 | : no initial description (android-javadoc)
WebExtension.java:2481 | : no initial description (android-javadoc)
WebExtension.java:2489 | : no initial description (android-javadoc)
WebExtension.java:2496 | : no initial description (android-javadoc)
WebExtension.java:2503 | : no initial description (android-javadoc)
WebExtension.java:2512 | : no initial description (android-javadoc)
WebExtension.java:1631 | : use of default constructor, which does not provide a comment (android-javadoc)
WebExtensionController.java:329 | : no initial description (android-javadoc)
WebExtensionController.java:568 | : use of default constructor, which does not provide a comment (android-javadoc)
WebRequest.java:238 | : no initial description (android-javadoc)
WebResponse.java:122 | : no initial description (android-javadoc)
WebResponse.java:131 | : no initial description (android-javadoc)
WebResponse.java:174 | : no initial description (android-javadoc)

This change was otherwise green, so I guess we just need to decide how to deal with these linter warnings and it can re-land.

Attached file Bug 1785296 - Bump JDK to 18.0.2+9. (obsolete) —
Severity: -- → N/A
Priority: -- → P3

Per discussion with Jon, we want to stick with the JDK LTS releases, which 18 is not. I'll file a new bug for updating to the latest 17.x release and repurpose this one to fixing the javadoc errors that will eventually bite us when the next LTS comes out.

Assignee: ryanvm → nobody
Summary: Update to JDK18 → Fix javadoc warnings that turn fatal with JDK18+
Attachment #9290333 - Attachment is obsolete: true
Whiteboard: [geckoview:2023h2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: