1785308 - Use the Popen cleanup hack in more places in runxpcshelltests.py

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, task)

Description

[Andrew McCreight [:mccr8]]

To work around a Python bug that was fixed in 2019 but is still present in the version of Python we use on Windows 7, runxpcshelltests.py basically clears subprocess._cleanup before it runs Popen() in one place, and restores it afterwards. However, there are two other places in that file that call Popen(). With my patches in bug 1769791, we seem to hit this issue when running the XPCShell self-tests.

I have a patch to wrap up the "cleanup hack" into a little contextmanager thing which can be used for all 3 Popen calls and which will hopefully fix the issue for me.

Comment 1

[Andrew McCreight [:mccr8]]

I found another reference to these self-tests failing with verify mode due to the popen issue. It is possible that my patch will fix that, but I'll leave it to somebody else to investigate if they want.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1785308 - Use the Popen cleanup workaround in more places in runxpcshelltests.py.

Comment 3

[Andrew McCreight [:mccr8]]

XPCShell tests look green on Win7 with this patch and my XUL changes. (They were always orange without this patch.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b79a8d87e74
Use the Popen cleanup workaround in more places in runxpcshelltests.py. r=jmaher

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5b79a8d87e74