178570 - mail startup painfully slow

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

something regressed in today's checkins, such that startup is really really
slow. It's as if we're opening all the local mail folder db's on startup,
instead of using the folder cache.

Comment 1

[David :Bienvenu]

Here's the problem:

nsMsgDBFolder::SetStringProperty calls GetDBFolderInfoAndDB, which will open the
db. nsMsgLocalMailFolder::CreateSubFolders(nsFileSpec &path) gets called for
every folder, which means for every local folder, we open the db. 

The reason for the folder cache is that it allows us to avoid opening the db for
every folder on startup. We can't call SetStringProperty on every local folder
every time we start up if it's going to open the db.

The way this should work is that if the pretty name hasn't changed, we shouldn't
be writing to the db. For this to work, we need to make sure that we've tried to
load the folder cache info for the folder by calling ReadDBFolderInfo(PR_FALSE)

Comment 2

[David :Bienvenu]

proposed fix upcoming.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

this is a temporary fix - make sure the name has changed before setting the
pretty name. I don't know how this will behave with japanese folder names, or
localized builds - it might mean that we open those db's every time on startup
as well, which would be unacceptable. I'm going to hand this over to Navin to
worry about, but we need to fix this ASAP.

Comment 4

[David :Bienvenu]

-> Navin.

Comment 5

[Navin Gupta]

Attachment: proposed fix

We don't need to set the prettyName if we got the name from db/cache in the
first place. Thanks david for catching this. Can you review it ? thx.

Comment 6

[Navin Gupta]

Comment on attachment 105285 [details] [diff] [review]
proposed fix

wrong patch!

Comment 7

[Navin Gupta]

Attachment: right patch

we need to set the diskname in case folder name is not present in the cache or
the db.

Comment 8

[David :Bienvenu]

Comment on attachment 105286 [details] [diff] [review]
right patch

r=bienvenu, should work.

Comment 9

[Navin Gupta]

fix checked in.

Comment 10

[Navin Gupta]

checked on ishmail branch.

Comment 11

[laurel]

This looks OK to me using 2003-01-13 commercial trunk.