Closed Bug 1785758 Opened 3 years ago Closed 3 years ago

Reduce overhead of AudibilityMonitor

Categories

(Core :: Audio/Video: Playback, enhancement)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

Details

Attachments

(1 file)

Bug 1785758 - Use linear gain threshold for audibility check to reduce overhead of AudibilityMonitor. r?#media-playback-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Rather than calculate dBFS for each sample to compare against the audibility threshold, convert the threshold to a linear value once and use that instead. A quick standalone benchmark shows this is ~17x faster.

Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5650d8c2cefa Use linear gain threshold for audibility check to reduce overhead of AudibilityMonitor. r=media-playback-reviewers,padenot

https://hg.mozilla.org/mozilla-central/rev/5650d8c2cefa

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: