1785764 - Color of all Wr* threads should be green for easier readability

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Mayank Bansal]

Example profile : https://share.firefox.dev/3AtGFja

All WR* threads should have the green color for easy discoverability/readability

Comment 1

[Julien Wajsberg [:julienw]]

My understanding is that we need to set a category using a frame label, but this is only rust code. Can we add frame labels from rust code? Nazim, do you know?

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Yeah, we need to add some categories to WebRender codebase. We have a new label frames API for Rust that we can use for that. See: https://firefox-source-docs.mozilla.org/tools/profiler/instrumenting-rust.html#adding-stack-frame-labels

This requires analyzing the webrender codebase and finding all the functions we run through rayon. I can take a look at it when I have some time, but ideally it would be a lot better if someone who knows webrender code can take a look.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Actually looking at the profile, it looks like the main entrance for these threads seems to be pretty much the same all the time. So we can probably easily add these. I will try to take a look at it.
As a start, it looks like these are the main entrances for some WR threads:

WRWorkerLP:
webrender_bindings::moz2d_renderer::rasterize_blob
WRRendererBackend:
webrender::renderer::init::create_webrender_instance
WRWorker:
webrender::glyph_rasterizer::GlyphRasterizer::flush_glyph_requests

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Hmm, it turns out it's not so easy to add labels for webrender::* ones because we can't have dependencies from the mozilla_central packages in that. We are only allowed to have through webrender_bindings. But since webrender_bindings only exposes a ProfilerHooks trait, we can't really use our RAII gecko_profiler_label macro inside, since it's designed to destruct the label once it goes out of scope. So we should figure out another option for these cases.
On the other hand, it's pretty easy to add a label to webrender_bindings::moz2d_renderer::rasterize_blob. Probably I will start with only that.

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1785764 - Add Graphics profiling category to some of the rasterization code paths r?gerald,#gfx-reviewers!

While looking at the some of the Rust threads in the profiler they were always
appearing gray, which are not easy to follow/understand. Adding
Graphics::Rasterization category to these code paths allows us to show the
appropriate category for WRWorker threads. It changes the category color to
green as well which is easier to follow and understand.

See the following profiler links:
Before: https://share.firefox.dev/3egkhRC
After: https://share.firefox.dev/3cGEcca
Timeline color is different as well as the colors in the Call Tree.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b97bfa3a045c
Add Graphics profiling category to some of the rasterization code paths r=gerald,gfx-reviewers,jrmuizel

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b97bfa3a045c