1785770 - [wpt-sync] Sync PR 35508 - FrameSet: Fix an integer overflow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35508 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35508
Details from upstream follow.

Kent Tamura <[e-mail]> wrote:

FrameSet: Fix an integer overflow

crrev.com/1035755 introduced an integer overflow:
(int * int) / int64_t
The type of the multiplication result is |int|, and can overflow.

This CL changes it like:
ClampTo\<int>((int * int64_t) / int64_t)

Bug: 1353277
Change-Id: Ib59d1a16762e139bf882a8619e344914339d535d
Reviewed-on: https://chromium-review.googlesource.com/3836624
WPT-Export-Revision: 6b6871017fc269181b5db2d859a5018f4f04ca49

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 35508 applied with additional changes from upstream: 572db7f1b6305bc2fcb6e43818ce32a43ce9947b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=539667af4330d7074460b41aff48d148afa785e9

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=245b4dd872dd685dd7026c59a29a96519e4d9c9f

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-cols-relsize.html [wpt.fyi]
  • A large relative value should not produce weird sizes.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-rows-relsize.html [wpt.fyi]
  • A large relative value should not produce weird sizes.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ac8631524d
[wpt PR 35508] - FrameSet: Fix an integer overflow, a=testonly

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/d7ac8631524d