Update text recognition support link
Categories
(Core :: DOM: Core & HTML, task, P2)
Tracking
()
People
(Reporter: gregtatum, Assigned: gregtatum)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Currently it's https://support.mozilla.org/%LOCALE%/kb/placeholder5
but it can be updated to:
https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/text-recognition
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
The link is now live.
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc3fbb40632d Update text recognition support link; r=nordzilla
Comment 4•2 years ago
|
||
Backed out changeset fc3fbb40632d (bug 1785837) for causing l10n-bump bustage.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a5176546a99fceee734d67f287ee36cf0f440161
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d05b33bebce Update text recognition support link; r=nordzilla CLOSED TREE
Comment 6•2 years ago
|
||
Backed out by mistake, bustages came from another bug.
Relanded patch
Comment 7•2 years ago
|
||
bugherder |
Assignee | ||
Comment 8•2 years ago
•
|
||
Comment on attachment 9291222 [details]
Bug 1785837 - Update text recognition support link; r?nordzilla
Beta/Release Uplift Approval Request
- User impact if declined: When a macOS user clicks the "Learn more" link in the modal when there are no results in the "Copy Text from Image" context menu modal, they will be directed to a 404. This is also only in early beta, as we are giving this feature an early trial.
- Is this code covered by automated tests?: Yes and no, the code around the link is tested, but the link's value is not asserted.
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's a change to a link address, not a behavior change. It's not covered by automated tests, as the link is programmatically generated. The code around it is exercised, but the link value is not verified in tests.
I see this as low risk as it's a smaller population, macOS-only on early beta, in a new feature, and in the lower probability scenario of extracting text from an image with no text.
- String changes made/needed: None
- Is Android affected?: No
Comment 9•2 years ago
|
||
Comment on attachment 9291222 [details]
Bug 1785837 - Update text recognition support link; r?nordzilla
Approved for 105.0b3.
Comment 10•2 years ago
|
||
bugherder uplift |
Description
•