1785853 - Close the FxA tab opened by Fx-View when sign-in is complete

Status: VERIFIED FIXED

(Firefox :: Firefox View, enhancement, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Fx-View opens a tab to allow the user to sign-in/sign-up to FxA. When that process is complete and the user returns to Fx-View, we could close that tab for them if its still open.

Comment 1

[:Gijs (he/him)]

Sam offered to check if we now automatically go back to fxview, and/or if we still need to do something to close the tab.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Screenshot 2022-09-01 at 11-32-35 Device connected.png

I do see the call to action button which correctly opens fx-view after both signing in and completing the pairing procedure with the mobile browser.

Provided the tab reference remains good, I think we should be able to keep that around when we open the tab to do the sync setup and close on re-entry into fx-view if the user has completed the setup.

We just need to be a little careful as I believe closing the last non-hidden tab in a window will also result in the window closing. And if that's the last window, the browser itself will quit! Maybe we should open an about:newtab tab if that's the case?

Comment 3

[:Gijs (he/him)]

(In reply to Sam Foster [:sfoster] (he/him) from comment #2)

Created attachment 9292708 [details]
Screenshot 2022-09-01 at 11-32-35 Device connected.png

I do see the call to action button which correctly opens fx-view after both signing in and completing the pairing procedure with the mobile browser.

I'm gonna ping Josh here as he said he still saw an issue so I'd like to just confirm that he's seeing the same thing (or if not, get to the bottom of why not). Josh: you should get a screen similar to the screenshot from Sam and clicking the button should switch tabs to Firefox View (though the tab where you signed in will stay open). Can you let us know if that matches what you're seeing?

Provided the tab reference remains good, I think we should be able to keep that around when we open the tab to do the sync setup and close on re-entry into fx-view if the user has completed the setup.

Yep, that sounds good.

We just need to be a little careful as I believe closing the last non-hidden tab in a window will also result in the window closing. And if that's the last window, the browser itself will quit! Maybe we should open an about:newtab tab if that's the case?

I think opening a new tab instead in that case sounds right, yes.

Comment 4

[Josh Berman]

Attachment: Screen Recording 2022-09-01 at 2.06.47 PM.mov

This is what's happening for me when I go through sign in.

Comment 5

[Josh Berman]

I did this again following Ray's instructions. It does work when you pair your mobile device. It redirects to Fx View

Comment 7

[Sarah Clements [:sclements]]

Attachment: Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster

• Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
• Add test coverage

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d91a621a39be
Close device connected tab after user returns to Firefox View r=sfoster

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for causing multiple failures e.g. browser_setup_state.js

• backout: https://hg.mozilla.org/integration/autoland/rev/3926ab043041cb7022dd4eca51646357c7a81cdc
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=d91a621a39beeee040335585582253defcfc5fcd
• failure logs:
  • TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_setup_state.js | Second tab is about: newtab - Got "blank", expected "newtab"
  • TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - Error: TelemetryStopwatch: key "FX_TAB_SWITCH_UPDATE_MS" was already initialized at updateCurrentBrowser@chrome://browser/content/tabbrowser.js:1059:28

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b1e2e6ceb70
Close device connected tab after user returns to Firefox View r=sfoster

Comment 11

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on browser_setup_state.js

Backout link

Push with failures

Failure log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/805306a553fb
Close device connected tab after user returns to Firefox View r=sfoster

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/805306a553fb

Comment 14

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build as well as our latest Beta 107.0b5.