1785942 - Construct JSStrings with constructors

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Steve Fink [:sfink] [:s:]]

Right now, we allocate some memory of the right size, cast it to a JSString subclass, and call some form of init() on it. C++ would be happier with us if we went through an actual constructor.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1785942 - Expose function that avoids some excess NUL termination

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1785942 - Use constructors for JSString subclasses.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1785942 - Move more allocation code into the friend-able js::gc::CellAllocator class (was struct)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/908782294278
Move more allocation code into the friend-able js::gc::CellAllocator class (was struct) r=arai
https://hg.mozilla.org/integration/autoland/rev/ba0222b20638
Expose function that avoids some excess NUL termination r=arai
https://hg.mozilla.org/integration/autoland/rev/a2664bf7445f
Use constructors for JSString subclasses. r=arai

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/908782294278
https://hg.mozilla.org/mozilla-central/rev/ba0222b20638
https://hg.mozilla.org/mozilla-central/rev/a2664bf7445f