1785954 - Set the devtools performance profiler default presets to Thunderbird instead of Web Developer on all channels

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

The web developer presets are pretty useless for Thunderbird, but they're the default on beta/release.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1785954 - Set the devtools performance profiler default presets to Thunderbird instead of Web Developer on all channels. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d21e5d75b74
Set the devtools performance profiler default presets to Thunderbird instead of Web Developer on all channels. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9290579 [details]
Bug 1785954 - Set the devtools performance profiler default presets to Thunderbird instead of Web Developer on all channels. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: profiler defaults to less useful settings
Testing completed (on c-c, etc.): in 105b1
Risk to taking this patch (and alternatives if risky): no

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9290579 [details]
Bug 1785954 - Set the devtools performance profiler default presets to Thunderbird instead of Web Developer on all channels. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 5

[Rob Lemley [:rjl]]

Attachment: c-esr102_additional.patch

When uplifting the original patch on this bug, I noticed that the devtools.performance.popup.feature-flag was not going to be in the resulting prefs file on c-esr102.
It was added in bug 1783770, but it looks completely unrelated to it and uplifting it is not feasible. So I grabbed just this pref change to land on c-esr102 so that there is consistency between release and beta.
It may not matter, the profiler docs state that the popup is not enabled for release anyway.

[Triage Comment]

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.3.0:
https://hg.mozilla.org/releases/comm-esr102/rev/c6f492dc67b8
https://hg.mozilla.org/releases/comm-esr102/rev/e978e08f3559

Comment 7

[Geoff Lankow (:darktrojan)]

I added the other preference in bug 1783770. We don't have the feature it enables so the code was just wasting time.