1785970 - User incorrectly identified as new after leaving Mozilla

Status: NEW

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

mikokm (userid 547538) is incorrectly being identified as "New to Bugzilla".

I believe this is what's happening:

• account created prior to employment
• account placed in mozilla-corporation group
  • at this point they had made 23 comments
  • get editbugs via mozilla-corporation, is no longer new

TagNewUsers tracks the number of comments in profiles.comment_count. This counter is updated when the user makes a comment, and stops incrementing once the user is no longer new.

Then:

• user makes another 2022 comments
• account removed from mozilla-corporation group
  • and from editbugs

So profiles.comment_count still contains 23 from before they got editbugs. Until they make a comment, which might never happen, they will be identified as "New to Bugzilla".

A possible fix is to update TagNewUsers to clear profiles.comment_count any time group membership changes to force a recalculation. We'd also need to run something to fix up existing accounts.

Comment 1

[Daniel Holbert [:dholbert]]

In the meantime, I granted miko canconfirm and editbugs again; I suspect he'll continue to chime in now and then, post testcases, etc. and I don't want him to be restricted from doing so.

That does seem to have removed the New to Bugzilla banner on his account, which is nice.