1786050 - Support denormalized color-lines in COLRv1 radial gradients

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

The implementation of radial gradients landed in bug 1740530 does not account for cases when the color line used to define the gradient has a range other than [0..1]. We do handle such color lines for linear and sweep gradients; we should do the same for radial gradients.

(I'm currently discussing this with Dominik at Google, who is working on the same issue for Chrome, to ensure that we converge on an interoperable result.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1786050 - Normalize color-line if endpoints are not [0.0, 1.0] when creating radial gradient. r=#gfx-reviewers

Comment 2

[Jonathan Kew [:jfkthame]]

Posting a WIP patch, but not flagging for review yet (pending discussion with Dominik of the expected rendering).

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1786050 - Add a reftest. r=#gfx-reviewers

The glyphs "b" and "c" here have radial gradients with non-[0..1] color stop ranges,
and are compared against versions with equivalent normalized gradients.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bddde4931caa
Normalize color-line if endpoints are not [0.0, 1.0] when creating radial gradient. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/7b0739cd3f8f
Add a reftest. r=gfx-reviewers,lsalzman

Comment 5

[Sandor Molnar[:smolnar]]

Backed out 4 changesets (bug 1786050, bug 1786796) for causing reftest failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/842fcf23f8d1d0f5ddd4788ebcd8a6fe3772040c

Push with failures

Failure log

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/2895842928e9
Backed out 4 changesets (bug 1786050, bug 1786796) for causing reftest failures. CLOSED TREE

Comment 7

[Jonathan Kew [:jfkthame]]

Ah, the new test depends on a variation font, which isn't supported on Win7. Adding a skip-if annotation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16d1b659b291
Normalize color-line if endpoints are not [0.0, 1.0] when creating radial gradient. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/23314917bc22
Add a reftest. r=gfx-reviewers,lsalzman

Comment 9

[Atila Butkovits]

Backed out for causing reftest failure at font-error-404-2.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1f82228e7cc6f7d6a179d3afaf01d947c28fe740

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=DW91eIxSRbqcOOMM2Dpq9Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=97fc4d3e59114b0d1762f6e4db91673d7565287e

Failure log: https://treeherder.mozilla.org/logviewer?job_id=388486741&repo=autoland&lineNumber=18256

Comment 10

[Jonathan Kew [:jfkthame]]

Re-landing with the spuriously-failing tests annotated, per bug 1786796 comment 9.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5548555aec8e
Normalize color-line if endpoints are not [0.0, 1.0] when creating radial gradient. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/8369aba15231
Add a reftest. r=gfx-reviewers,lsalzman

Comment 12

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/5548555aec8e
https://hg.mozilla.org/mozilla-central/rev/8369aba15231