1786142 - Bootstrap script fails with vcs git

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Mark Straver]

I've set up a new environment for building on Windows 11. Followed the documentation instructions on the source docs site.

1. I installed VS2022, and the latest SDK for Windows 11
2. I installed Mozillabuild-latest
3. I installed Git for Windows (2.37)
4. I grabbed the latest bootstrap.py script as instructed on the source site
5. I attempted to perform a bootstrap using git as cvs, as documented python3 bootstrap.py --vcs=git

The following error was thrown and I could not clone:

$ python3 bootstrap.py --vcs=git
Cloning into mozilla-unified using Git...
Destination directory for clone (leave empty to use default destination of mozilla-unified):
Attempting to add exclusion path to Microsoft Defender Antivirus for: C:\source\mozilla-unified
Attempting to add exclusion path to Microsoft Defender Antivirus for: C:\mozilla-build\
Attempting to add exclusion path to Microsoft Defender Antivirus for: C:\Users\mcwer\.mozbuild
Cloning Firefox Git repository to mozilla-unified
Could not bootstrap Firefox! Consider filing a bug.
Traceback (most recent call last):
  File "C:\source\bootstrap.py", line 432, in <module>
    sys.exit(main(sys.argv))
  File "C:\source\bootstrap.py", line 399, in main
    srcdir = clone(options)
  File "C:\source\bootstrap.py", line 345, in clone
    return git_clone_firefox(binary, dest, watchman)
  File "C:\source\bootstrap.py", line 187, in git_clone_firefox
    st = os.stat(cinnabar)
FileNotFoundError: [WinError 2] The system cannot find the file specified: 'C:\\Users\\mcwer\\AppData\\Local\\Temp\\tmpbslh20lb\\git-cinnabar-master\\git-cinnabar'

Comment 1

[Ted Campbell [:tcampbell]]

I hit the same problem. The contents of the git-cinnabar repo changed slightly. As well the git-cinnabar download.py script checks git revisions, so this probably needs to just do a git depth=1 clone instead of using the github archive link.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1786142 - Use actual git clone when bootstrapping git-cinnabar in mozboot

The upstream git-cinnabar repo no longer has the git-cinnabar scripts which
breaks the logic in mozboot. We no longer need to worry about making those files
executable and can simply use the download.py script to do the work. For the
current versions of download.py to work correctly, we need the git metadata to
exist, so use a --depth=1 clone instead.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a49fae482f7c
Use actual git clone when bootstrapping git-cinnabar in mozboot r=firefox-build-system-reviewers,andi

Comment 4

[Mark Straver]

Thanks for the quick fix :)
So, eh, do i have to patch this myself or how will this deployed? Can I just grab the new script somewhere?

Comment 5

[Ted Campbell [:tcampbell]]

The URL pointed to in the build instructions will automatically get the update in a couple hours. If you want something immediately, you can use https://hg.mozilla.org/integration/autoland/raw-file/default/python/mozboot/bin/bootstrap.py
(This is similar to the other url but from the integration branch, while the link in the docs is for nightly which will merge twice a day).

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a49fae482f7c

Comment 7

[Mark Straver]

(In reply to Ted Campbell [:tcampbell] from comment #5)

The URL pointed to in the build instructions will automatically get the update in a couple hours. If you want something immediately, you can use https://hg.mozilla.org/integration/autoland/raw-file/default/python/mozboot/bin/bootstrap.py
(This is similar to the other url but from the integration branch, while the link in the docs is for nightly which will merge twice a day).

Thanks, I appreciate the instructions -- obviously not that much in a hurry for this, I was just wondering how and how fast the rollout would be for infra scripts like this :)

Comment 8

[Mark Straver]

Attachment: cinnabar-log.txt

Unfortunately this didn't resolve the issue.
Seems the problem now is that cinnabar can't install because of a certificate issue?

Failure log attached.

Comment 9

[Mike Hommey [:glandium]]

That's a completely separate issue. Please file a new bug.

Comment 10

[Mark Straver]

All right. Filed bug 1787370 for the follow-up