1786161 - [css-shapes-1] Implement rect() function

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Sebastian Zartner [:sebo]]

The CSS Shapes 1 specification defines a rect() function to create a rectangular shape as insets from the reference box similar to the inset() function.

This bug is meant to implement that function.

Sebastian

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1786161 - Support rect() function.

Note that rect() computes to the equivalent inset() function as well.
i.e. Given rect(t r b l), the equivalent function is
inset(t calc(100% - r) calc(100% - b) l).

The implementation is straightforward, and we don't have to change
anything in cpp because it is always inset() when building the gfx::Path.

The tests for clip-path will be added in the following patch.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1786161 - Add rect() tests for clip-path.

Also, move the interpolation of xywh() into
clip-path-interpolation-xywh-rect.html.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/014ccd272ac6
Support rect() function. r=devtools-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/fbce1db481ca
Add rect() tests for clip-path. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41169 for changes under testing/web-platform/tests

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/014ccd272ac6
https://hg.mozilla.org/mozilla-central/rev/fbce1db481ca

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/014ccd272ac6
https://hg.mozilla.org/mozilla-central/rev/fbce1db481ca

Comment 8

[Dipika]

MDN doc updates for this feature can be tracked via this issue: https://github.com/mdn/content/issues/28287 (in review).
Thanks Boris for all your help!