1786174 - Update Android linter to the latest version

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

The in-tree copy is 30.0.3, but 30.2.2 is the latest. Along the way, we'll need to fix up some issues the newer linter flags:

TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebPushUtils.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/rule/GeckoSessionTestRule.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/gecko/MultiMap.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/RemoteManager.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/ServiceAllocator.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoResult.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoView.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebExtension.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebRequest.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
TEST-UNEXPECTED-ERROR | mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebResponse.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)

While I'm here, I'm also going to clean up some other warnings I noticed in the logs:

Warning: org.mozilla.geckoview.WebExtension.ContextFlags: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
Warning: org.mozilla.geckoview.WebExtension.MenuItem.Type: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
Warning: org.mozilla.geckoview.WebExtension.Download.DownloadState: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
Warning: org.mozilla.geckoview.WebExtension.Download.DownloadInterruptReason: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
Warning: org.mozilla.geckoview.WebExtension.DownloadRequest.ConflictActionFlags: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Green on Try:
https://treeherder.mozilla.org/jobs?repo=try&revision=33c6086af1f1799d756cc84543f3af937108ae0f

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1786174 - Update Android linter to v30.2.2 and fix newly-flagged errors.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1786174 - Fix some other WebExtension warnings from the linting logs.

Depends on D155152

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/019896a91d2d
Update Android linter to v30.2.2 and fix newly-flagged errors. r=geckoview-reviewers,jonalmeida
https://hg.mozilla.org/integration/autoland/rev/1f317259d299
Fix some other WebExtension warnings from the linting logs. r=geckoview-reviewers,calu

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/019896a91d2d
https://hg.mozilla.org/mozilla-central/rev/1f317259d299