1786246 - [New users] The “Skip this step” button from the “Import Data” screen is no longer correctly displayed

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: SkipThisStepButton.png

[Affected versions]:

• Firefox Nightly 105.0a1 (Build ID: 20220821185924)

[Affected Platforms]:

• macOS 12.5.1
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the Firefox browser installed and opened.
• Have the “browser.aboutwelcome.templateMR” pref set to true.

[Steps to reproduce]:

1. Restart the browser and navigate to the “about:welcome” page.
2. Click the “Skip this step” button until the “Import Data” screen is displayed.
3. Observe the “Skip this step” button from the bottom-right corner of the screen.

[Expected result]:

• The “Skip this step” button is correctly displayed and contains its label.

[Actual result]:

• A tiny gray button without a label is displayed.

[Regression Window]:

• The issue is not reproducible with older Nightly 105.0a1 builds. Considering this using mozregression tools, I have found the regression range. Here are the results:
  Last good revision: 1d022fd2c07541e725479a3070e5ef4a513c5ac4
  First bad revision: a5fd749503d01b1fed163a3a8d0c190f69cdd978
  Pushlog: link

From this pushlog it seems that Bug 1781378 may have introduced this behavior.

[Notes]:

• The button is actionable.
• Attached is a screenshot of the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:jprickett, since you are the author of the regressor, bug 1781378, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: SecondaryButton_PinPrivateModal.png

• After further investigations, I noticed that this issue is also reproducible on the "Pin Private Window" modal from the existing users' onboarding.
• I managed to reproduce this issue only in the following locales: en-*, ru, zh-TW.

Comment 3

[Jason Prickett]

Attachment: Bug 1786246 - MR Onboarding Private Pin Skip Step button fix r=mardak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f25ca07da077
MR Onboarding Private Pin Skip Step button fix r=Mardak

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f25ca07da077

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 106.0a1 (Build ID: 20220823070106) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.

• The “Skip this step” button is correctly displayed and contains its label on both the "Import Data" screen and the "Pin Private Window" modal.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1781378

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jprickett, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.