(In reply to :Gijs (he/him) from comment #6)
(In reply to Anna Yeddi [:ayeddi] from comment #5)
(In reply to Morgan Reschenberg [:morgan] from comment #4)
Hi, it looks like now the landmarks are navigation, main, and complementary, where "main" contains both the tab pickup and recently closed sections. These sections are not individually distinct as landmarks. Complementary is the colorways section. It's a bit odd to have the colorways section identifiable as its own landmark, but tab pickup and recently closed be one "thing" (especially if we plan to keep the focus order as tab pickup, colorways section, recently closed)
That said, this is probably fine, but I'll pass this to Anna who has a better idea of frontend a11y :)
Agree that having them both in one
main landmark is fine if the Colorways
complimentary is not focused in-between. As it still is, I'd say having each one of them as a
region with appropriate accessible name by
aria-labelledby as it is marked up in HTML is a good solution too
I'm confused - does this mean this is now already fixed and we can close this bug without further code changes? Morgan appears to say "no", and your comment appears to say "yes", as it references the current source code which Sarah explained in comment #2 should mean this is now addressed (and that seems to match your comment).
(worth noting that having the focus order get to colorways last is already tracked separately in bug 1780239)
Tab pickup and
Recently Closed are now their own widgets within one
<main>, as per Sam's comment and corresponding patch. This should provide sufficient distinction between these two widgets.
Colorways landmark appears to be appropriate on wider screens and without magnification/browser zoom. Its when it gets injected between widgets of the main landmark on smaller screens and/or with magnification/browser zoom, it is a bit odd. But I think the
<section> pattern does improve it - and fixes this bug, imo.