Closed Bug 1786399 Opened 2 years ago Closed 2 years ago

Fix named page fragmentation on flexbox and other non-block-level frames

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: alaskanemily, Assigned: alaskanemily)

References

Details

Attachments

(1 file)

As per the CSS page3 spec, the page property only applies to frames that can create class-A breakpoints. From the fragmentation spec, this is only block-level frames and layout orthogonal table components, and does not include flex items.

This does fix issues with flex-box items, but does not yet handle table layout.

Pushed by emcdonough@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81c8d6a2d6f9
Check for block layout when applying and propagating page-name properties r=dholbert

Backed out for causing reftest failures on page-name-zero-height-001.html
Backout link
Push with failures
Link to failure log
Failure line :
REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/css-page/page-name-zero-height-001.html == layout/reftests/css-page/page-name-zero-height-001-ref.html | image comparison, max difference: 251, number of differing pixels: 165

Flags: needinfo?(emcdonough)
Pushed by emcdonough@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df2b7f7b94a5
Check for block layout when applying and propagating page-name properties r=dholbert

Failures should have been fixed in the updated change for bug 1779645

Flags: needinfo?(emcdonough)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: