1786468 - [meta] DoSomethingResult etc should be wrapped as `Result<DoSomethingResult, nsresult>`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, *Result classes of editor such as CreateElementResult have error state. However, it's not useful if the caller's return type is Result<Something, nsresult>, and they duplicates getter/checker method of error state. Therefore, they should not have error state and used as the success value.

E.g.,

Result<CreateElementResult, nsresult> result = DoSomething();
if (result.isErr()) {
  return Err(result.unwrapErr());
}
RefPtr<Element> newElement = result.UnwrapNewNode();
result.IgnoreCaretPointSuggestion();

should be:

CreateElementResult result = DoSomething();
if (result.isErr()) {
  return Err(result.unwrapErr());
}
RefPtr<Element> newElement = result.inspect().UnwrapNewNode();
result.inspect().IgnoreCaretPointSuggestion();