Remove some unnecessary includes from js/src/{frontend,gc,vm}
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Remove some includes from js/src/{frontend,gc,vm} which aren't needed per IWYU.
|
Assignee | |
Comment 1•2 years ago
|
||
This one was extra tricky, because removing includes from header files in
"js/src/vm" often leads to build errors in other files due to missing header
files which were previously only transitively included.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D155342
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D155343
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/53910f7dd1f8 Part 1: Remove unnecessary includes in js/src/vm. r=jonco https://hg.mozilla.org/integration/autoland/rev/5723d1994900 Part 2: Remove unnecessary includes from js/src/gc. r=jonco https://hg.mozilla.org/integration/autoland/rev/64c823e0df9c Part 3: Remove unnecessary includes from js/src/frontend. r=jonco
|
||
Comment 5•2 years ago
|
||
Backed out for causing SM failures on jsrtfuzzing.cpp . CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line :
/builds/worker/checkouts/gecko/js/src/shell/jsrtfuzzing/jsrtfuzzing.cpp:133:8: error: use of undeclared identifier 'ToInt32'
|
|
Assignee | |
Comment 6•2 years ago
|
||
Let's see if it now sticks. Hopefully there aren't any other build configurations which relied on the removed header includes.
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1fb01ce743b3 Part 1: Remove unnecessary includes in js/src/vm. r=jonco https://hg.mozilla.org/integration/autoland/rev/934e9608148c Part 2: Remove unnecessary includes from js/src/gc. r=jonco https://hg.mozilla.org/integration/autoland/rev/498d812eb398 Part 3: Remove unnecessary includes from js/src/frontend. r=jonco
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1fb01ce743b3
https://hg.mozilla.org/mozilla-central/rev/934e9608148c
https://hg.mozilla.org/mozilla-central/rev/498d812eb398
Description
•