1786505 - The "Colorways" modal for existing users is wrongly displayed if an expired theme is applied to the browser

Status: RESOLVED INVALID

(Firefox :: Messaging System, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: expired colorway.gif

[Affected versions]:

• Firefox Beta 105.0a1
• Firefox Nightly 106.0a1 - Build ID: 20220822190304

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.7
• Linux Mint 20.2 x64

[Prerequisites]:

• Have the following prefs in the "about:config" page:
• "devtools.chrome.enabled" set to "true";
• "browser.theme.colorway-closet" set to "false"
• "browser.aboutwelcome.templateMR" set to "true";
• Have the "Browser Console" opened.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Change the system's time to 01/30/2022 and restart the browser.
3. Navigate to the "about:addons" page and select the "Themes" section.
4. Enable an old colorway theme (e.g. Cheese Puff)
5. Change the system time to present and restart the browser.
6. Focus the "Browser Console" and run the Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog(); code.
7. Navigate through the Onboarding flow for the existing users and observe the displayed modals.

[Expected result]:

• The "Colorways" modal is not displayed.

[Actual result]:

• The "Colorways" modal is displayed in the Onboarding flow.

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

@mcoman MY understanding this is expected as the current onboarding colorway screen implementation checks for an active colorway collection available. If available, colorway screen is displayed with the colorways option.

https://searchfox.org/mozilla-central/rev/d01591796d5faccf762adb09a311d8ee12f7ca7f/browser/components/newtab/lib/OnboardingMessageProvider.jsm#919

NI product to help confirm this is expected behavior. Thanks

Comment 2

[Ania]

The "Colorways" modal is displayed in the Onboarding flow.

This is the expected result, the modal is correctly displayed right now, with user's expired theme in the chrome intact and with the correct copy.

I think this acceptance criterion has caused confusion:

• If a Colorways collection is expired, this screen is not displayed at all. *
  This was an acceptance criterion for when there's no active Colorways collection at all, rather than the user's collection is expired.
  For "Independence voices" collection, this will happen Jan 23, 2022.

The user's expired or non-expired theme is governed by this acceptance criterion:

• For the representation of the system default (for new users) and the user's existing theme a separate option with the description ~ "Use my current Firefox colors" text is displayed. (this is from the spec, so the copy here is not final)*