Closed Bug 1786511 Opened 3 years ago Closed 3 years ago

Pulling Snap from Launchpad should ignore empty debug package in SHA256SUMS

Categories

(Toolkit :: Crash Reporting, enhancement)

Product:
Toolkit
Component:
Crash Reporting
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(2 files)

GitHub Pull Request
50 bytes, text/x-github-pull-request
Details | Review
Bug 1786511 - Check for missing size when verifying SHA256SUMS on mozilla/symbol-scraper r?gsvelto!
48 bytes, text/x-phabricator-request
Details | Review

https://bugzilla.mozilla.org/show_bug.cgi?id=1782734#c5 and https://bugzilla.mozilla.org/show_bug.cgi?id=1782734#c11

We have had a Snap produced a few days ago in each case, with the same version number, but no debug symbols, so it is already added to the SHA256SUMS list and we skip the new versions.

Maybe when checking existence within SHA256SUMS we should account also for:

  • matching size of .snap file as well as .debug file
Attached file GitHub Pull Request —
Blocks: 1782734
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/024f1d0a67a3 Check for missing size when verifying SHA256SUMS on mozilla/symbol-scraper r=gsvelto

https://hg.mozilla.org/mozilla-central/rev/024f1d0a67a3

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: