1786523 - [Enhancement] Open the “Sign in” link from the intro screen of the “about:welcome” page in a new tab

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Simona Rosu [:srosu], Ecosystem QA]

[Affected versions]:

• Firefox 106.0a1 Build ID: 20220823070106
• Firefox Beta 105.0b1 Build ID: 20220822142820

[Affected Platforms]:

• Windows 10 x64
• macOS 12.5.1
• Ubuntu 20.02

[Prerequisites]:

• Have the Firefox browser installed and opened.
• Have the “browser.aboutwelcome.templateMR” pref set to true.

[Steps to reproduce]:

1. Navigate to the “about:welcome” page.
2. Click the “Sign in” link from the top-right corner of the page.
3. Observe what happens.

[Expected result]:

• The “Continue to Firefox accounts” page is opened in a new tab and it is focused.

[Actual result]:

• The “Continue to Firefox accounts” page is opened in the same tab, and the Onboarding flow ends.

[Notes]:

• We consider that this enhancement will improve the user experience. With the current behavior, if the “Sign in” link is clicked, the user no longer has the chance to interact with the Onboarding flow.

Comment 1

[Punam Dahiya [:pdahiya]]

This has been the existing behavior in onboarding. NI @Ania for feedback on this enhancement Thanks

Comment 2

[Ania]

Simona and I discussed this would be a worthwhile change so that we leave an opportunity for users choosing to click the Sign in to complete the onboarding (as chances they will return from the Sign in via back button are very low).
We also know that a sizable proportion of people doesn't finish the Sign if flow started from about:welcome, so it feels valuable to provide the door to onboarding "open".
I think it would be nice to address this for 106, but not critical.

Comment 3

[Emily McMinn :emcminn]

Attachment: Bug 1786523 - Add a where prop to FXA Accounts to allow opening in a new tab

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a224934d4790
Add a where prop to FXA Accounts to allow opening in a new tab r=negin

Comment 5

[Sandor Molnar[:smolnar]]

Backed out changeset a224934d4790 (bug 1786523) for causing multiple failures in browser_siteData_multi_select/browser_aboutwelcome_multistage_mr

Backout link: https://hg.mozilla.org/integration/autoland/rev/3c63ce92457890468bf11fe7161851ed45d16fd9

Push with failures

Failure log browser_aboutwelcome_multistage_mr

Failure log browser_siteData_multi_select

Comment 6

[Emily McMinn :emcminn]

Sorry for the delay on this - it got set aside in favor of some P1s. I've been able to reproduce the test failure, that's being caused by the default onboarding being slightly different between platforms; I'll have to tweak the tests to handle the edge cases.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bb553525a67
Add a where prop to FXA Accounts to allow opening in a new tab r=negin,pdahiya

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5bb553525a67

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 107.0a1 (Build ID: 20221013224755) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

• The “Continue to Firefox accounts” page is opened in a new tab but it’s not focused.
  @Ania, could you please confirm if that tab should be focused? Thanks!

Comment 10

[Ania]

Yes, that's a correct behavior, thank you for confirming, Simona!

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

Thank you, Ania, for confirming this! I filed a new issue (Bug 1795832) and based on comment 9, I'm marking this one as Verified.