1786535 - firefox-android: Migrate android-components jobs on PR

Status: RESOLVED FIXED

(Release Engineering :: General, task)

Description

[Johan Lorenzo [:jlorenzo]]

We should leverage what was done in bug 1783690 and use it to make pull requests graphs green.

Comment 1

[Johan Lorenzo [:jlorenzo]]

⚠️ I had to deactivate PRs when dealing with bug 1783690, since graphs were still red. Re-enabling them should be a matter of reverting this commit[1]

[1] https://github.com/mozilla-mobile/firefox-android/commit/68fecc0752b3c3adc66ebff89e528dddefbd1d77

Comment 2

[Geoff Brown [:gbrown]]

https://github.com/mozilla-mobile/firefox-android/pull/5
https://firefox-ci-tc.services.mozilla.com/tasks/Vt9EhL40Q-K2p-kqn7Dqeg/runs/0/logs/public/logs/live.log

triggers a scopes error: missing queue:route:tc-treeherder.v2.firefox-android.git-pr.bff15feedf507ebd8a67cf1d6e851e59cf2285bd.0

but comparing firefox-android and android-components, the routes and scopes for the Decision tasks are the same.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Oh, I see what's wrong! It's subtle. The called out "missing" scope is queue:route:tc-treeherder.v2.firefox-android.git-pr.{rev}.0. Note the .git part.

ci-configuration grants queue:route:tc-treeherder.v2.firefox-android-pr.*[1]. .git isn't present in the scope.

As you said, android-components declares the same scope[2]. So the problem is not on the ci-configuration side. The fact that the firefox-android repo is private forces us to use the SSH URL which ends in .git. I don't know where but I wouldn't be surprised if somewhere in taskgraph or in firefox-android, a function assumes that the name of the repo is the end of [e-mail]:mozilla-mobile/firefox-android.git no matter if it ends with .git or not.

[1] https://firefox-ci-tc.services.mozilla.com/auth/roles/repo%3Agithub.com%2Fmozilla-mobile%2Ffirefox-android%3Apull-request
[2] https://firefox-ci-tc.services.mozilla.com/auth/roles/repo%3Agithub.com%2Fmozilla-mobile%2Fandroid-components%3Apull-request

Comment 4

[Geoff Brown [:gbrown]]

Yes, that's the difference! Thanks!

Comment 5

[Geoff Brown [:gbrown]]

https://github.com/taskcluster/taskgraph/pull/104

Comment 6

[Johan Lorenzo [:jlorenzo]]

Mass edit: The move to the monorepo was officially announced 2 days ago[1]. No need to keep these tickets confidential anymore.

[1] https://github.com/mozilla-mobile/android-components/issues/12751

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeff153d9785
Make PR tasks pass