1786597 - [Colorway Closet] Changing between Soft/Balanced and Bold themes doesn't switch the modal styling to dark or light mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Victoria Wang [:victoria]]

Seen today with the latest Nightly. Didn't work like this yesterday.

When I use the Colorway Closet from either Firefox View or Addons, and switch between light and bold intensity for any color, the modal itself doesn't get updated for light/dark mode.

Comment 1

[Dão Gottwald [:dao]]

I suspect this is a regression from bug 1782596. Emilio, can you confirm this? (In case you're not aware, the Colorways modal can be opened from about:addons -> Themes.)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1782596

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1786597 - Make sure that content-color-scheme only affects the tab content's browser. r=dao

Otherwise the selector also matches the <browser> inside the tab-modal
dialog for example.

Before bug 1782596 it wasn't honored, because those were not top-level
browsing contexts, but now it is.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9edf089685ed
Make sure that content-color-scheme only affects the tab content's browser. r=dao

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9edf089685ed

Comment 6

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 and 11 x64, Ubuntu 20.04 x64 and on macOS 11.6.