Closed Bug 1786604 Opened 2 years ago Closed 2 years ago

[Colorway Closet] Always give modal some side margin to make it clear that it's a modal

Categories

(Firefox :: Theme, enhancement, P2)

Product:
Firefox
Component:
Theme
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: victoria, Assigned: dao)

References

Details

(Whiteboard: [fidefe-colorway-closet])

Attachments

(2 files)

image.png
823.38 KB, image/png
Details
Bug 1786604 - Add horizontal margin to dialogBox. r=pbz
48 bytes, text/x-phabricator-request
Details | Review

There should always be some margin around the colorways modal to make it clear that it's a modal. This is especially a concern in dark mode where there's less contrast between the modal and the dark mode background.

The exact amount of margin for such modals will be a longer conversation with Design Systems, and should change based on browser width, but for the sake of a stop gap solution for this MR, I would suggest a minimum 24px wide margin for all resolutions.

Related to #1786371

Summary: [Colorway Closet] Always give modal some side margin to clarify that it's a modal → [Colorway Closet] Always give modal some side margin to make it clear that it's a modal
Attached image image.png —
Blocks: colorway-closet
Whiteboard: [fidefe-colorway-closet]
Priority: -- → P2
Assignee: nobody → dao+bmo
Points: --- → 1
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a14641b4d61
Add horizontal margin to dialogBox. r=pbz

https://hg.mozilla.org/mozilla-central/rev/3a14641b4d61

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: