1786627 - Colorway Closet section on Firefox View page — For Light and Balanced themes, should use the light mode button coloring

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Victoria Wang [:victoria]]

Attachment: image.png

In Firefox View's colorway promo, if the user has chosen a Light or Balanced colorway, we should use the white on dark blue (light mode) button coloring.

The current dark mode button can look pretty garish against some of the light background colors.

Comment 1

[Dão Gottwald [:dao]]

So the problem is the page is using new tab colors, disregarding color scheme settings, while also depending on common-shared.css which respects color scheme settings.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1786627 - Let contentTheme.js set the color scheme so common-shared.css can honor it. r=sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a6e9812b8c
Let contentTheme.js set the color scheme so common-shared.css can honor it. r=sfoster

Comment 4

[Cristian Tuns]

Backed out for causing mochitest failures on browser_ext_themes_ntp_colors.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors.js | New tab page should have lwt-newtab attribute - false == true - got false, expected true (operator ==)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8801f1d0ec0a
Let contentTheme.js set the color scheme so common-shared.css can honor it. r=sfoster

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8801f1d0ec0a

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue from comment 0 using old Nightly build from 2022-08-23. Verified that using Firefox 106.0b5 across platforms (Windows 10, macOS 11.6 and Ubuntu 21.04) all the colorways themes (soft and balanced) plus light theme, will have the darker blue and white text on the buttons.