Update strings on a privacy segmentation card
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
People
(Reporter: asafko, Assigned: jprickett)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Hi Jason,
We had to make adjustments to the strings to the Privacy Segmentation screen to make localization easier. Can I please ask you to update the strings based on this final-final Figma?
Thank you!
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed by jprickett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ea00ad2c5aa Updating MR Onboarding Privacy Segmentation strings r=flod,fluent-reviewers DONTBUILD
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
||
Comment 4•2 years ago
|
||
Comment on attachment 9291383 [details]
Bug 1786892 - Updating MR Onboarding Privacy Segmentation strings r=flod
Beta/Release Uplift Approval Request
- User impact if declined: There is no user impact, as these strings are not actively used by code yet, by they exist in mozilla-beta and are exposed for localization for the next 3 cycles.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Strings are unused, this is just to avoid churn for localizers.
- String changes made/needed: Yes
- Is Android affected?: No
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9291383 [details]
Bug 1786892 - Updating MR Onboarding Privacy Segmentation strings r=flod
Approved for 105.0b3.
|
|
||
Comment 6•2 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
I have verified this enhancement with the "browser.privacySegmentation.preferences.show" pref set to "true" in the "about:config" page, and I can confirm that the strings from the "Privacy Segmentation" card respect the "Figma" specifications.
Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220918214503) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.
Description
•