1786899 - Clean up some parts of BrowserSearch

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

BrowserSearch.loadAddEngines is no longer used:

https://searchfox.org/mozilla-central/search?q=symbol:%23loadAddEngines&redirect=false

We should remove that, and simplify the calls to BrowserSearch.searchEnginesURL - there's no need for them to find a window to get the url.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1786899 - Remove unused BrowserSearch.loadAddEngines and remove formatURL. r?jteow!

formatURL is only used in one other place - nsContextMenu.js, so we don't really need that when we can call the necessary function direct.

Also moves searchEnginesURL into SearchUIUtils, as that seems a reasonable place to start storing things like that.

Comment 2

[Mark Banner (:standard8)]

I'm going to extend this to add a little bit more clean up of BrowserSearch as well.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1786899 - Remove unused uri argument to BrowserSearch.addEngine. r?jteow

Depends on D155496

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df17de492f56
Remove unused BrowserSearch.loadAddEngines and remove formatURL. r=jteow,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/0e30991b60e7
Remove unused uri argument to BrowserSearch.addEngine. r=jteow

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/df17de492f56
https://hg.mozilla.org/mozilla-central/rev/0e30991b60e7