1786900 - Hitting secondary CTA on colorways screen after navigating back resets to system theme

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to fix an edge case in new user onboarding that resets user previously applied colorway in the same session.

STR:

1. Open about:welcome
2. Navigate to colorway screen, select a colorway theme and hit Set colorway
3. Colorway should be applied. Navigate back to colorway screen by hitting back button
4. Click secondary CTA

Expected Result:
Previous selected colorway should stay applied

Actual Result:
Theme gets reset back to system theme

Comment 1

[Punam Dahiya [:pdahiya]]

The issue happens because initialTheme state doesn't get reset with the active theme in the same session until reload of about:welcome

https://searchfox.org/mozilla-central/rev/d01591796d5faccf762adb09a311d8ee12f7ca7f/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#322

This edge case doesn't happen in current omnboarding because Theme screen is the last screen and hit of back reloads about:welcome

Comment 2

[Punam Dahiya [:pdahiya]]

NI @Ania to help triage this edge case Thanks

Comment 3

[Ed Lee :Mardak]

This looks like it'll be fixed as part of bug 1783750.

Comment 4

[Ania]

I'd treat it as a nice-to-fix, but a fairly low-priority one. I don't think it's critical for 106, but would be nice to tackle long-term for the sake of keeping up predictable behavior after returning to a previous screen via a back button.

Comment 5

[Ed Lee :Mardak]

Fixed with bug 1783750

https://hg.mozilla.org/mozilla-central/rev/8a106238a536

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (106.0a1 Build ID - 20220830092750) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. Now, I can confirm that the previously set theme remains active after hitting the "Skip this step" button.