1786902 - Secondary CTA is not clickable on Language Mismatch screen while screen is downloading langpack

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

Attachment: Getting available languages screenshot

Scope of this bug is to fix an edge case on language mismatch screen. Secondary CTA on Language mismatch screen has label skip and stays inactive while the screen is downloading lang pack (See attached).

STR in local dev:

1. Clobber and build locally

2. Launch firefox using below command line script
   ./mach run --setpref "extensions.getAddons.langpacks.url=https://mock-amo-language-tools.glitch.me/?app=firefox&type=language&appversion=%VERSION%" --setpref "intl.multilingual.aboutWelcome.languageMismatchEnabled=true" --setpref "intl.multilingual.aboutWelcome.systemLocaleOverride=es-CO" --setpref browser.aboutwelcome.templateMR=true -- about:welcome

3. Navigate to Language mismatch screen

Expected Result:

1. Click of secondary CTA should navigate user to next screen

Actual result:

1. Secondary CTA is not clickable

Comment 1

[Ed Lee :Mardak]

Looks like an issue from bug 1784901 adding .action-buttons to the custom buttons for language switcher https://searchfox.org/mozilla-central/rev/642be079c4465445ab42b55d18e0a4d644c19c36/browser/components/newtab/content-src/aboutwelcome/components/LanguageSwitcher.jsx#182

where there ends up being another empty .action-buttons with no buttons inside https://searchfox.org/mozilla-central/rev/642be079c4465445ab42b55d18e0a4d644c19c36/browser/components/newtab/content-src/aboutwelcome/components/MultiStageProtonScreen.jsx#289

but now there's overlap because they're both height 100% https://searchfox.org/mozilla-central/rev/642be079c4465445ab42b55d18e0a4d644c19c36/browser/components/newtab/content-src/aboutwelcome/aboutwelcome.scss#307

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784901

Comment 3

[Negin]

Attachment: Bug 1786902 - Secondary CTA is not clickable on Language Mismatch screen while screen is downloading langpack

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8033ca96d4e3
Secondary CTA is not clickable on Language Mismatch screen while screen is downloading langpack r=dmose

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8033ca96d4e3

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (106.0a1 Build ID - 20220830092750) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. Now, I can confirm that the secondary CTA button from the "Download langpack" screen of the "about:welcome" page is functional and performs the correct action.

Also, during the verification, I have observed that the secondary button is labeled "Skip" instead of "Skip this step", however, I have logged a separate issue for that (see Bug 1788044 )