1786920 - "Enter your password for..." dialog is missing the server name when getting messages (incl. fix for bug 1792102: POP3 messages not deleted on server)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[softwarewebresearch]

Attachment: Thunderbird 102.1.2 64-bit enter password get messages dialog bug - works on send message

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

Get Messages

Actual results:

The "Enter your password for..." dialog is missing the server name in both the title bar and the body when getting messages. When sending messages, the dialog is correct in both the title bar and the body. Redacted screenshots attached showing both dialogs.

Expected results:

The server name should be in both the title bar and the body. This was the case in v91. The bug was introduced in v102.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1786920 - Show hostname in pop3 password dialog, prevent showing multiple auth dialogs. r=mkmelin

The bug is server.hostname should be server.hostName.
Take the chance to refactor MsgIncomingServer and MailAuthenticator a bit to prevent showing multiple auth dialogs for the same server.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/855c9b464e08
Show hostname in pop3 password dialog, prevent showing multiple auth dialogs. r=mkmelin

Comment 4

[Ping Chen [:rnons] (away)]

Comment on attachment 9291465 [details]
Bug 1786920 - Show hostname in pop3 password dialog, prevent showing multiple auth dialogs. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: POP3 password dialog title and message don't have hostname
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[softwarewebresearch]

Thanks for the fast fix...very much appreciated!

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9291465 [details]
Bug 1786920 - Show hostname in pop3 password dialog, prevent showing multiple auth dialogs. r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[softwarewebresearch]

Approved for beta

Glad to hear it!

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 105.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/bb5925e89f23

Comment 9

[softwarewebresearch]

Thunderbird 105.0b2

Great news! Thanks again!

Comment 11

[Ping Chen [:rnons] (away)]

Attachment: 1786920-esr102.patch

Because of conflicts, only pick the necessary changes to uplift to esr102.

[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: POP3 password dialog title and message don't have hostname
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): no risk

Comment 13

[Ping Chen [:rnons] (away)]

Attachment: 1786920-esr102.patch

Because of conflicts, only pick the necessary changes to uplift to esr102.

[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: POP3 password dialog title and message don't have hostname, and bug 1792102
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): no risk

Also includes fix for bug 1792102

Comment 14

[Thomas D. (:thomas8)]

(In reply to Ping Chen (:rnons) from comment #13)

Regression caused by (bug #): bug 1707548
User impact if declined: POP3 password dialog title and message don't have hostname, and bug 1792102
Also includes fix for bug 1792102

Thank you very much Ping for fixing this and also bug 1792102 in the process, which is currently collecting duplicates. I agree that we should keep bug 1792102 as a separate bug in its own right for best bug management.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9296277 [details] [diff] [review]
1786920-esr102.patch

[Triage Comment]
Approved for esr102

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 102.3.1:
https://hg.mozilla.org/releases/comm-esr102/rev/f51f869beeef

Comment 19

[Ping Chen [:rnons] (away)]

Attachment: 1786920-esr102-prevent-multiple-auth-dialogs.patch

Rebase the other half of the original patch to esr102, which essentially fixes bug 1792879.
[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: Multiple password dialog may be shown for the same account
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Did a try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=edfb0af60fa3d03e3e05e8bd75b895b31781ff53

Comment 20

[softwarewebresearch]

I just updated to 102.3.1 (64-bit). The fix for POP server name works perfectly! Thanks very much for the quick fix!

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9296745 [details] [diff] [review]
1786920-esr102-prevent-multiple-auth-dialogs.patch

[Triage Comment]
approved for esr102

Comment 23

[Ping Chen [:rnons] (away)]

Can we uplift the above patch? Thanks.

Comment 24

[Rob Lemley [:rjl]]

(In reply to Ping Chen (:rnons) from comment #23)

Can we uplift the above patch? Thanks.

Yes! Sorry this got missed. The bug was set to "fixed" after the initial uplift in comment 16. Once that happens it's difficult to catch anything else that gets added (like comment 19). You can set the status flag to "affected" in these cases.

I'll get this into the next build.

Comment 25

[Rob Lemley [:rjl]]

Thunderbird 102.4.2:
https://hg.mozilla.org/releases/comm-esr102/rev/a1060c5f6569