1787033 - Commands (shortcuts) do not work in regular messageDisplay windows any more

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling (:TbSync)]

STR by max (Bug 1644038 Comment 20):

Problem: Function passed to browser.commands.onCommand.addListener is not invoked when focused window has messageDisplay or messageCompose type.

Comment 1

[John Bieling (:TbSync)]

It is not regressed by bug 1644038. I can reproduce the reported bug in Daily where that bug has not landed yet.

Comment 2

[John Bieling (:TbSync)]

ESR102 is affected as well, when the activeTab permission is requested.

Upstream code at m-c removed a check for that permission and now a certain piece of code is executed for all extensions and not only for those requesting the activeTab permission and that code dies on us - I assume since forever.

Comment 3

[John Bieling (:TbSync)]

Attachment: Bug 1787033 - Return activeTab for non-mail windows as well. r=#thunderbird-reviewers

Comment 4

[John Bieling (:TbSync)]

Try run for check-in:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=b50cabf81976cf007b1707d8735db0d7214735dc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c2fe7afcf7be
Return activeTab for non-mail windows as well. r=aleca

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9291509 [details]
Bug 1787033 - Return activeTab for non-mail windows as well. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: We do not return the correct active tab for non-mail windows.
Testing completed (on c-c, etc.): On BETA for 2 month.
Risk to taking this patch (and alternatives if risky): Minimal change, should be low.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9291509 [details]
Bug 1787033 - Return activeTab for non-mail windows as well. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.3.3:
https://hg.mozilla.org/releases/comm-esr102/rev/82fafd671e4e