1787087 - system-symbols-mac docker images are busted with src/common/dwarf/elf_reader.cc:200:15: error: 'strcmp' is not a member of 'std'; did you mean 'strcmp'?

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

src/common/dwarf/elf_reader.cc: In constructor 'google_breakpad::ElfSectionReader<ElfArch>::ElfSectionReader(const char*, const string&, int, const typename ElfArch::Shdr&)':
src/common/dwarf/elf_reader.cc:200:15: error: 'strcmp' is not a member of 'std'
     if ((std::strcmp(name, ".strtab") == 0 ||
               ^~~~~~
src/common/dwarf/elf_reader.cc:200:15: note: suggested alternative:
In file included from src/common/dwarf/elf_reader.cc:35:
/usr/include/string.h:136:12: note:   'strcmp'
 extern int strcmp (const char *__s1, const char *__s2)
            ^~~~~~
src/common/dwarf/elf_reader.cc:201:15: error: 'strcmp' is not a member of 'std'
          std::strcmp(name, ".shstrtab") == 0) &&
               ^~~~~~
src/common/dwarf/elf_reader.cc:201:15: note: suggested alternative:
In file included from src/common/dwarf/elf_reader.cc:35:
/usr/include/string.h:136:12: note:   'strcmp'
 extern int strcmp (const char *__s1, const char *__s2)
            ^~~~~~

The underlying problem is that building the docker image builds whatever version of breakpad is current at the time the docker image is built (and thus is not reproducible and a constant time bomb)

Comment 1

[Mike Hommey [:glandium]]

Comes from this upstream change: https://chromium.googlesource.com/breakpad/breakpad/+/f1f7b5272fdf105592fc262a9adaab55a3621122%5E%21/

Comment 2

[Gabriele Svelto [:gsvelto]]

Time to get breakpad out of the way, we can use the new dump_syms here.

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1787087 - Remove breakpad's dump_syms from the macOS system symbols scrapers and use the Rust one instead r=glandium

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cc1d718e530
Remove breakpad's dump_syms from the macOS system symbols scrapers and use the Rust one instead r=glandium

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2cc1d718e530

Comment 6

[Intermittent Failures Robot]

1 failures in 3293 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• taskcluster-images: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1787087&startday=2022-08-22&endday=2022-08-28&tree=all