1787096 - unify nsIMsgIncomingServer hostName casing to hostname

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/67d0cc5a0cafa09b46c42b72e70090149dd081df/mailnews/base/public/nsIMsgIncomingServer.idl#59 is using camel cased hostName.

This has caused a few bugs in a year (latest bug 1786920), and I'm sure a bunch of extra debugging work during development. It's just error prone. We should lowercase it to hostname like nsISmtpServer. The server pref is already lowercase like mail.server.server1.hostname, which further adds to this confusion.

Comment 1

[Ping Chen [:rnons] (away)]

I guess this may break some extensions.

Comment 2

[Magnus Melin [:mkmelin]]

Probably shouldn't backport, so I would assume this is a very minor change. For compat they can even keep the old spelling and just have it forward to the new one.

Comment 3

[Wayne Mery (:wsmwk)]

Same as bug 1520439 ?

Comment 4

[Magnus Melin [:mkmelin]]

No.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1787096 - unify nsIMsgIncomingServer hostName casing to hostname. r=tobyp

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/de1a046069fa
unify nsIMsgIncomingServer hostName casing to hostname. r=tobyp

Comment 7

[Francesco (no longer active, use PM for contact)]

Should username be unified as well?
https://hg-edge.mozilla.org/comm-central/rev/de1a046069fa#l53.57
And a few lines down: nsAutoCString userName;

Comment 8

[Magnus Melin [:mkmelin]]

For incoming/outgoing servers there's already no difference (both username). Sure, there's some local misspellings (and the pref name, which can't be easily change), but I don't plan to do anything for those atm as it's more or less harmless.

This bug OTOH was frequently causing problems.