1787101 - [CTW] OffsetAtPoint doesn't transform to HyperText offsets

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

STR:

1. Open this test case:
   data:text/html,<p>a<span>b</span></p>
2. Get the coordinates for the "b" character.
3. Call OffsetAtPoint on the paragraph with the coordinates from 2).
   • Expected: It should return 1.
   • Actual: It returns 0.

The reason for this is simple: we return a TextLeafPoint offset without transforming it to a HyperText offset. I totally should have caught that during review, but I clearly didn't. We need to call TransformOffset on that offset before returning it.

The fix is easy. Testing it is going to be more annoying because of the usual pain that comes with dealing with coordinates.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1787101: HyperTextAccessibleBase::OffsetAtPoint: Transform the offset before returning it.

Otherwise, the returned offset is incorrect if the point is in a child other than the first.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0be134b13d29
HyperTextAccessibleBase::OffsetAtPoint: Transform the offset before returning it. r=morgan

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0be134b13d29