1787115 - The user's theme is changed to the system's one if the "Skip this step" or "current colors" button from the existing's user "Colorways" modal is clicked

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 106.0a1 - Build ID: 20220824213405

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.7
• Linux Mint 20.2 x64

[Prerequisites]:

• Have the following prefs in the "about:config" page:
  • "devtools.chrome.enabled" set to "true";
• Have the "Browser Console" opened.
• Have a custom theme applied from "about:addons>Themes".

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Focus the "Browser Console" and run the Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog(); code.
3. Navigate through the Onboarding modals until the "Colorways" one is displayed.
4. Click the "Skip this step" button and observe the browser's theme.

[Expected result]:

• The existing user theme is still enabled.

[Actual result]:

• The theme is changed to the system theme.

[Additional Notes]:

• The user set theme is also reset to the system one if the "Default" theme option from the "Colorways" modal is selected.
• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

Bug 1783750 help address reset for built in themes , but reported Issue exists for custom theme

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1787115 - Allow Colorways onboarding modal to restore user-installed themes. r?pdahiya

This is the simplest approach I could think of to allow the welcome screen to
revert back to any theme the user had installed initially. The reason this
wasn't working previously is just that the surface could only retrieve built-in
addon IDs. If we reserve a property for an active non-built-in theme, then the
behavior will be the same for built-in themes and user-installed themes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4b72690ced0
Allow Colorways onboarding modal to restore user-installed themes. r=pdahiya

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c4b72690ced0

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (106.0a1 Build ID - 20220909093917) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. Now, I can confirm that the previously user set theme is no longer changed if the "Skip this step" or "current colors" button from the existing's user "Colorways" modal is clicked.