1787122 - Crash in [@ mozilla::net::CookieServiceParent::UpdateCookieInContentList]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

14 reports from 8+ installations on all desktop operating systems.

Crash report: https://crash-stats.mozilla.org/report/index/64e3cde4-2270-4c2a-b0bc-fc8150220825

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (NS_SUCCEEDED(CookieCommons::GetBaseDomain(mTLDService, uri, baseDomain, requireAHostMatch)))

Top 10 frames of crashing thread:

0 libxul.so mozilla::net::CookieServiceParent::UpdateCookieInContentList netwerk/cookie/CookieServiceParent.cpp:138
1 libxul.so mozilla::net::CookieServiceParent::TrackCookieLoad netwerk/cookie/CookieServiceParent.cpp:116
2 libxul.so mozilla::dom::ContentParent::AboutToLoadHttpFtpDocumentForChild dom/ipc/ContentParent.cpp:6211
3 libxul.so mozilla::net::HttpChannelParent::OnStartRequest netwerk/protocol/http/HttpChannelParent.cpp:1073
4 libxul.so mozilla::net::DocumentLoadListener::FinishReplacementChannelSetup netwerk/ipc/DocumentLoadListener.cpp:1245
5 libxul.so {virtual override thunk} 
6 libxul.so mozilla::MozPromise<bool, nsresult, false>::ThenValue<mozilla::net::HttpChannelParent::ContinueVerification xpcom/threads/MozPromise.h:846
7 libxul.so mozilla::MozPromise<bool, nsresult, false>::ThenValueBase::ResolveOrRejectRunnable::Run xpcom/threads/MozPromise.h:487
8 libxul.so mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:851
9 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1205

Comment 1

[Armin Ebert [:arminius]]

Just stumbled upon this. Here's a testcase:

<script>
window.location = "http://a...example.com/"
</script>

(IMO looks somewhat severe because essentially a fairly common typo may unexpectedly crash the parent.)

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I had this crash today when I was opening website page
https://crash-stats.mozilla.org/report/index/39518f13-ee39-41ff-80ee-0267c0220828

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 6

[Ed Guloien [:edgul]]

Attachment: Bug 1787122 - Fixed assert crash when attempting to get base domain from a malformed URL. r=kershaw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b27d9c0f5596
Fixed assert crash when attempting to get base domain from a malformed URL. r=kershaw

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b27d9c0f5596

Comment 9

[Intermittent Failures Robot]

2 failures in 3537 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform and build breakdown:

• linux1804-32-shippable-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1787122&startday=2022-08-29&endday=2022-09-04&tree=all