1787130 - Double separator in context menu before extension items

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[max]

Steps to reproduce:

Try an extension that creates a context menu item having

contexts: [ "message_list", "page", "frame", "selection", "link", "image", "video", "audio", ]

for various objects: messages in the list, text, links, selected fragments in the message body. Pay attention to appearance of the context menu.

Actual results:

Sometimes double line separating add-on item is added, sometimes it is just single line.

The problem appeared around thunderbird-102, perhaps a bit earlier and has not fixed in current builds. Thunderbird-91 is not affected or maybe there is space between double line so it appears as a bit thicker one.

Linux, KDE.

Expected results:

Context menu items added by add-ons always separated by a single line.

Comment 1

[John Bieling (:TbSync)]

Try run:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=55074259352f2e08b1accf4d3394e4ce8134a37c

Could you check if this fixes all of the reported cases for you, and if you see a regression, this patch could have introduced?

Comment 2

[John Bieling (:TbSync)]

Attachment: Bug 1787130 - Fix double separator for webExt menu entries. r=aleca

Comment 3

[John Bieling (:TbSync)]

Updated try run:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=311e1bb628f1e076a480c7b586be94ff72b2ef2a

Comment 4

[max]

(In reply to John Bieling (:TbSync) from comment #3)

Updated try run:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=311e1bb628f1e076a480c7b586be94ff72b2ef2a

Thank you. I have not tried hard to check various scenarios, but at least in the following cases I do not see double separator any more:

• Message list
• Message body page, selection
• mailto: link in the message body (for http: links double separator does not appear even in "public" builds)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45d0d89ca3fc
Fix double separator for webExt menu entries. r=aleca

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9294384 [details]
Bug 1787130 - Fix double separator for webExt menu entries. r=aleca

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Double seperator in context menu.
Testing completed (on c-c, etc.): On BETA for 1 month.
Risk to taking this patch (and alternatives if risky): Should be fine. Tested with a local build.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9294384 [details]
Bug 1787130 - Fix double separator for webExt menu entries. r=aleca

[Triage Comment]
Approved for esr102

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.3.3:
https://hg.mozilla.org/releases/comm-esr102/rev/216f03fabe8d

Comment 9

[Ben Bucksch (:BenB)]

I still see the bug in 102.5.0 on Linux,
with context "folder_pane", on folders. It's working correctly in the context menu for accounts, but not for folders.

The bug appears when there are multiple items added by the same extension. The double separator appears in the moment when the submenu opens.

Comment 10

[Ben Bucksch (:BenB)]

Filed bug 1801675 about that, as continuation of this bug here.