1787159 - The media sniffer sometimes fails to sniff AAC in ADTS when the AAC stream has more than two channels

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Paul Adenot (:padenot)]

We cap the sniffing at 512 bytes, but testing by encoding a number of files, we can have absolutely huge frame size, e.g.:

sox -V -r 48000 -n -b 16 -c 8 sin1k.wav synth 30 sin 1000 vol -10dB && ffmpeg -i sin1k.wav -ar 8000 -b:a 320000 out.aac

results in a file that, according to our ADTS demuxer, has a first frame that is 4277 bytes, well beyond the 512 bytes cap. It's an 8 channels AAC file, CBR at 320kbps, 8000Hz sample-rate, which is kind of a weird file, but easy to make.

I'm going to cap the sniffing at 8k.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1787159 - Fix sniffing for AAC in ADTS with big AAC frames. r?alwu

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1787159 - Test that AAC packets in ADTS with big frames can be sniffed. r?alwu

Depends on D155585

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1787159 - It can be necessary to sniff more data in some cases. r?#necko-reviewers

Sometimes, media needs more than 512 bytes to determine the content type.

Depends on D155586

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1787159 - Test that a 6 channels ADTS file with large AAC frames can be decoded. r?alwu

Depends on D155587

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e7451eb44d9
Fix sniffing for AAC in ADTS with big AAC frames. r=alwu
https://hg.mozilla.org/integration/autoland/rev/fe795b47f5ea
Test that AAC packets in ADTS with big frames can be sniffed. r=alwu
https://hg.mozilla.org/integration/autoland/rev/99c8eac7322c
It can be necessary to sniff more data in some cases. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/bf145275b8a9
Test that a 8 channels ADTS file with large AAC frames can be decoded. r=alwu

Comment 6

[Sandor Molnar[:smolnar]]

Backed out 4 changesets (bug 1787159) for causing mochitest failures in dom/media/webaudio/test/test_decodeMultichannel.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/417e3f05462077748f8dcf1a2c453236f6197627

Push with failures

Failure log mda

LE. Failure log xpc

TEST-UNEXPECTED-FAIL | dom/media/webaudio/test/test_decodeMultichannel.html | Decoding 8kHz-320kbps-8ch.aac failed)

Comment 7

[Paul Adenot (:padenot)]

Hrm the MFT for AAC only support 6 channels, too bad. I'm going to lower the number of channels here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ae487b3afeb
Fix sniffing for AAC in ADTS with big AAC frames. r=alwu
https://hg.mozilla.org/integration/autoland/rev/c095a999a3db
Test that AAC packets in ADTS with big frames can be sniffed. r=alwu
https://hg.mozilla.org/integration/autoland/rev/a78016cc2812
It can be necessary to sniff more data in some cases. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/8bbff0f18e88
Test that a 6 channels ADTS file with large AAC frames can be decoded. r=alwu

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing AAC related build bustages

Backout link

Push with failures

Failure log

Failure line: package-tests> Error: Symlink target path does not exist: /builds/worker/checkouts/gecko/toolkit/components/mediasniffer/test/unit/data/8kHz-320kbps-6ch.aac

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ff8337743bd
Fix sniffing for AAC in ADTS with big AAC frames. r=alwu
https://hg.mozilla.org/integration/autoland/rev/ad0cc19207ce
Test that AAC packets in ADTS with big frames can be sniffed. r=alwu
https://hg.mozilla.org/integration/autoland/rev/0f9e3836fef5
It can be necessary to sniff more data in some cases. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/333d1c3b1139
Test that a 6 channels ADTS file with large AAC frames can be decoded. r=alwu

Comment 11

[Atila Butkovits]

Backed out for causing failures at test_ext_webRequest_eventPage_StreamFilter.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1e5b6ed21adb1c5595e9b0e6c288f09efd9bca4c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=333d1c3b11396a5bbf5de38ba8926e8ed02cad81&selectedTaskRun=YmhmXa7GR9irwebt6O-l8A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=389736307&repo=autoland&lineNumber=5479

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d47242ec79
Fix sniffing for AAC in ADTS with big AAC frames. r=alwu
https://hg.mozilla.org/integration/autoland/rev/ce530399c45a
Test that a 6 channels ADTS file with large AAC frames can be decoded. r=alwu

Comment 13

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/03d47242ec79
https://hg.mozilla.org/mozilla-central/rev/ce530399c45a