Closed Bug 1787262 Opened 2 years ago Closed 2 years ago

H1 styles should be 1.5em and 600 weight

Categories

(Firefox :: Firefox View, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: jberman, Assigned: kcochrane)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(3 files)

Actual: "Independent Voices" is 1.8em and font-weight: bold. Tab pickup and Recently closed are 1.5em and font-weight: 500
Expected: "Independent Voices", "Tab pickup" and "Recently closed" are 1.5em and font-weight: bold

Severity: -- → S4
Priority: -- → P3

I'm confused. The design actually has weight: 700 (and Metropolis) for the Tab pickup and Recently closed headers. I expect we approximated with 500 because the fonts are different to begin with and so different font-weights make things look "wrong" compared with the design.

The "Independent Voices" header is also noticeably bigger in the design than the other headers.

Can you clarify what exactly should change, and if this is a change to the design as well?

Flags: needinfo?(jberman)
Attachment #9292248 - Attachment description: Screenshot showing much larger colorways header vs tab pickup / recently closed headers → Screenshot from figma showing much larger colorways header vs tab pickup / recently closed headers

The 500 font weight isn't appearing substantial enough with system fonts, but the Independent voices carries a "bold" style which more closely maps to the weight we see in the figma file (visually). In terms of the size of Independent Voices text, the Figma Files were actually a bit inconsistent and sometimes showed the that header with a larger font size and sometimes showed it with the same font size. The way it's appearing now on the website though, it really messes with the hierarchy and makes the colorways section feel like the most important thing there, when semantically this isnt true.

Flags: needinfo?(jberman)

Also, the reason I suggested bold is because it appears from inspecting the independent voices text, that text carries a "bold" font size and that looks ok.

I just put in 600 weight and that looks better too.

500 is just a little too light.

Summary: H1 styles should be 1.5em and bold → H1 styles should be 1.5em and 600 weight

Updated bug to reflect discussion

Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/221a543d8c03
Update h1 font size and weight in Fx View to match Figma spec r=dao
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: