1787264 - Thunderbird installer and updater create Windows desktop shortcuts with different names

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect, P2)

Description

[alkorang]

Attachment: 2.png

Steps to reproduce:

1. Install old version of Thunderbird (at the time of writing, 102.1.0) with exe installer on Windows.
2. Press Alt-H then A to open Mozilla Thunderbird Information. Then update to the latest version (at the time of writing, 102.2.0) and restart.

Actual results:

After 1, you'll see the installer creates "Mozilla Thunderbird" shortcut in Windows desktop.
After 2, you'll see the updater creates "Thunderbird" shortcut in Windows desktop.
The updater sometimes failes to rename or remove "Mozilla Thunderbird" shortcut, leaving both shortcuts, "Mozilla Thunderbird" and "Thunderbird".

Expected results:

The installer and updater should use one consistent name for their desktop shortcuts on Windows, either "Mozilla Thunderbird" or "Thunderbird".

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1787264 - Port bug 1413295: Rename shortcuts from "Mozilla Thunderbird" to "Thunderbird". r=Paenglab

Bug 1675918 added the UpdateShortcutsBranding macro and started runnuing it
post-update. This macro renames "Mozilla Thunderbird" shortcuts to "Thunderbird".
However, bug 1413295 was never ported to the Thunderbird installer, so the
installer still created "Mozilla Thunderbird" shortcuts which got renamed
on update.

Comment 2

[alkorang]

Attachment: 1.png

I also observed the same issue in start menu.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/21d80aae7237
Port bug 1413295: Rename shortcuts from "Mozilla Thunderbird" to "Thunderbird". r=Paenglab

Comment 4

[Rob Lemley [:rjl]]

This bug cannot be tested effectively with the Thunderbird Daily build as ${BrandFullName} is set to "Thunderbird Daily" and ${BrandShortName} is also set to "Thunderbird Daily". There is no difference in the installed shortcuts after updating.

I'll do some testing on Thunderbird 106.0b1 when it's released next week. Thomas, could you verify as well?

Comment 5

[Rob Lemley [:rjl]]

(In reply to Rob Lemley [:rjl] from comment #4)

This bug cannot be tested effectively with the Thunderbird Daily build as ${BrandFullName} is set to "Thunderbird Daily" and ${BrandShortName} is also set to "Thunderbird Daily". There is no difference in the installed shortcuts after updating.

I'll do some testing on Thunderbird 106.0b1 when it's released next week. Thomas, could you verify as well?

To clarify what needs checking:

• Fresh install of Thunderbird 106.0b1 installs Desktop/Start Menu shortcuts named "Thunderbird" - not "Mozilla Thunderbird"
• Upgrading previous beta to 106.0b1 should rename existing shortcuts from "Mozilla Thunderbird" to "Thunderbird"
• Uninstall 106.0b1 should remove both variants of shortcut names. (not 100% sure about this one)

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9294523 [details]
Bug 1787264 - Port bug 1413295: Rename shortcuts from "Mozilla Thunderbird" to "Thunderbird". r=Paenglab

[Approval Request Comment]
Regression caused by (bug #): 1675918
User impact if declined: Start Menu and Desktop shortcuts change names and/or are duplicated
Testing completed (on c-c, etc.): Beta since 106.
Risk to taking this patch (and alternatives if risky):
Low risk, I did not see any issues in testing on beta. There may be stray shortcuts left over that won't get cleaned up.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9294523 [details]
Bug 1787264 - Port bug 1413295: Rename shortcuts from "Mozilla Thunderbird" to "Thunderbird". r=Paenglab

[Triage Comment]
Approved for esr102

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.4.2:
https://hg.mozilla.org/releases/comm-esr102/rev/ba46e4f63203