Closed Bug 1787512 Opened 3 years ago Closed 2 years ago

Update Glean.js to use single method for triggering restart events

Categories

(Data Platform and Tools :: Glean: SDK, task, P4)

Product:
Data Platform and Tools
Component:
Glean: SDK
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: brosa, Unassigned)

Details

In the test suite for Glean.js, there are multiple ways that we trigger the glean.restarted event. We want to update all the places where these events are triggered and use a single function for this. The instances where we are generating errors result from setting the timestamp to before the current moment - this is possible within the testRestartGlean function you just need to pass a negative value.

We can also refactor this function to fit whatever needs we have for triggering restarts, but ideally we want a single way to do this.

https://github.com/mozilla/glean.js/pull/1452/files#diff-f568945105bf3a92425e89f6cc6c2a71a08962450d937d89fcb8422dac9698b7R20

Priority: -- → P4

This doesn't need to happen. The way that we generate these events right now are only in tests and work fine.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.