1787552 - nsIWindowsShellService::PinCurrentAppToTaskbarAsync breaks icon when called repeatedly

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Beth Rennie [:beth] (she/her)]

Attachment: the new shortcut icon

If you already have Firefox pinned and call

Cc["@mozilla.org/browser/shell-service;1"]
  .getService(Ci.nsIWindowsShellService)
  .pinCurrentAppToTaskbarAsync(false)

it will change the icon of your currently pinned Firefox. The same behaviour occurs if you do not have Firefox pinned and call the function twice.

If you call it with true instead, the same behaviour happens for the private browsing shortcut.

Comment 1

[[e-mail] (:bhearsum)]

I think this is probably not a problem in practice right now as I believe all calls to this are guarded behind checkPinCurrentAppToTaskbar - but we ought to fix this regardless to avoid a future footgun.

Comment 2

[Nick Rishel [:nrishel]]

P3 S4 given we suspect this is more of a future hazard than a current concern.

Comment 3

[Nipun Shukla]

Attachment: Bug 1787552 - Added check to see if taskbar pin already exists before pinning in PinCurrentAppToTaskbarWin10 r=nrishel

pinning in PinCurrentAppToTaskbarWin10 r=nrishel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f88f4a17483
Added check to see if taskbar pin already exists before pinning in PinCurrentAppToTaskbarWin10 r=nrishel

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7f88f4a17483